Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove type and browser attributes from package.json #260

Merged
merged 1 commit into from
Mar 22, 2021
Merged

fix: remove type and browser attributes from package.json #260

merged 1 commit into from
Mar 22, 2021

Conversation

ericdeansanchez
Copy link
Contributor

No description provided.

@ericdeansanchez ericdeansanchez requested a review from a team as a code owner March 18, 2021 17:46
@commit-lint
Copy link

commit-lint bot commented Mar 18, 2021

Bug Fixes

  • remove type and browser attributes from package.json (baec4cf)

Contributors

ericdeansanchez

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ericdeansanchez ericdeansanchez mentioned this pull request Mar 18, 2021
Closed
luqven
luqven reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@luqven luqven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 , but will leave it to Fred and / or Sherwin to approve since I'm not as familiar with how removing "browser" will affect things downstream.

frederickfogerty
frederickfogerty approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's do it 👍

@ericdeansanchez ericdeansanchez merged commit c9304f3 into main Mar 22, 2021
@ericdeansanchez ericdeansanchez deleted the compat2 branch March 22, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqven luqven luqven left review comments

@frederickfogerty frederickfogerty frederickfogerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericdeansanchez @frederickfogerty @luqven