Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Requests fail for non-contributor PRs due to Travis not setting environment variables. #148

Closed
frederickfogerty opened this issue Jun 28, 2018 · 0 comments · Fixed by #150
Closed

Pull Requests fail for non-contributor PRs due to Travis not setting environment variables. #148

frederickfogerty opened this issue Jun 28, 2018 · 0 comments · Fixed by #150
Labels
Priority: High Status: Review Needed Type: Bug Type: Maintenance

Comments

@frederickfogerty
Copy link
Contributor

Currently, Pull Requests submitted by non-contributors fail on CI because the integration tests fail. This is because Travis does not provide environment variable to outsiders' Pull Requests for safety reasons, and so the tests cannot log in to BrowserStack.

The testing logic can be updated to run integration tests for contributors, and just headless tests on chrome for others.

See here for an example of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Status: Review Needed Type: Bug Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): disable browserstack for community PRs imgix/react-imgix
1 participant
@frederickfogerty