chore(ci): disable browserstack for community PRs #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickfogerty
changed the title
jayeb
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, Pull Requests submitted by non-contributors failed on CI because the integration tests failed. This is because Travis does not provide environment variable to outsiders' Pull Requests for safety reasons, and so the tests could not log in to BrowserStack.
This PR updates the CI configuration to run all tests for contributors, and only run integration tests on Chrome and Firefox for community PRs.
This fixes #148
Steps to Test
Steps:
BROWSERSTACKkeys from https://travis-ci.org/imgix/react-imgix/settings