fix: warn the user when no <img> passed as a child to <picture> fixes #90 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickfogerty
requested review from
modosc and
jayeb
and removed request for
modosc
jayeb
approved these changes
Jul 3, 2018
|
@jayeb I would appreciate your thoughts on the problem described above ☝️🙌 |
|
The component-splitting you brought up in #144 seems like a good idea on its own, and if it also happens to solve our problem here then that's just gravy. |
|
Great, thanks @jayeb. I'm going to merge this into |
frederickfogerty
added a commit
that referenced
this pull request
Aug 15, 2018
* version-8: docs: add link to fluid example and fix some links docs: add example about fitting to the size of the container docs: add ref information feat: refactor picture and source behaviour into different components (#163) feat: reduce props API surface area (#162) feat: implement responsiveness with srcSet and sizes (#159) fix: warn the user when no <img> passed as a child to <picture> fixes #90 (#151) # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: A fallback image will no longer be created when using react-imgix in picture mode
Description
The fallback image support when using react-imgix in
picturemode was causing issues with sizing in #90 as the size being passed to the rootpicturecomponent was being used for the fallback as well. This was causing problems, and the simplest solution was to remove the fallback image creation. This is inline with the HTML spec, so anyone used to using<picture>elements in HTML will be at home with this. There is more discussion in #90.A problem here is that
srcis a required prop for react-imgix, which will cause an error when usingpicturemode as asrcnow isn't going to be passed to the root component. An option we have here is to update thesrcprop to not be required, and just to warn the user when asrcis not passed when the component is being used inimg,bg, orsource. Another option is to wait to see if we implement the splitting of components as described in #144. In either way this needs to be discussed and resolved before this PR is merged.Also, since this is a breaking change, I'm going to merge this into the
version-8branch, and I'll look to land all the breaking changes at once (e.g. the ones being discussed in #144).This PR fixes #90
Bug Fix
fix(<area>): fixed bug #issue-numberSteps to Test
Observe the changes to the unit tests in
test/unit/react-imgix.test.js