-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement responsiveness with srcSet and sizes #159
Merged
Merged
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
560385c
chore(readme): fix typo and update codesandbox examples (#158)
frederickfogerty c03401a
chore(jest): upgrade jest to support new expect functions
frederickfogerty 0070943
test: use srcset and sizes
frederickfogerty 1bb6808
chore: update build:watch to build es instead of commonjs
frederickfogerty 9c504c9
feat: add constants file and targetWidths from imgix.js
frederickfogerty ccdbfcf
test: mock window.screen for unit tests
frederickfogerty d21c5ea
feat: use srcset and sizes
frederickfogerty 0392518
Merge branch 'version-8' into fred/use-srcsets
frederickfogerty 26b0035
test: refactor alt test
frederickfogerty 88eb552
test: refactor ixlib tests to use expectSrcTo
frederickfogerty 6438f15
chore: stop using ...other in props
frederickfogerty 7116c15
chore: rename support.js -> constructUrl.js
frederickfogerty fac1757
feat: add fallback srcset when using sizes
frederickfogerty df2db05
feat: update targetWidths with up to date reses, and remove max restr…
frederickfogerty fa7860c
chore: remove fixed TODO
frederickfogerty 9cf4365
docs: update README for new srcSet/sizes
frederickfogerty 8322693
test: add srcSet test for <source>
frederickfogerty 93a5dfb
feat: use 2x and 3x srcSets for pictures
frederickfogerty 6719d24
docs: update markdown link
frederickfogerty a7cbe47
docs: add sizes doc
frederickfogerty 7af8394
chore: cleanup unused code
frederickfogerty c4750f1
chore: update targetWidth
frederickfogerty ecc0e84
feat: remove type=bg and add reference to issue
frederickfogerty 78c25f0
chore: remove availWidth and availHeight constants as they're not used
frederickfogerty 8108460
chore: update fit logic
frederickfogerty 4e53375
test: remove type=bg tests
frederickfogerty a6cc892
docs: remove reference to unimplemented aspect ratio behaviour
frederickfogerty 28b074a
docs: add upgrade guide
frederickfogerty 9167095
chore: refactor some code to be more readable
frederickfogerty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but what's up with the bit about
w
andh
scaling properly? This isn't exemplified in the above code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I was planning to do this but didn't get around to it. I might pull this out and put it in a separate issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from PR and added to #161