feat: expose url builder api #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
suggested changes
Nov 19, 2018
README.md
Outdated
| @@ -22,7 +22,7 @@ A [React](https://facebook.github.io/react/) component that renders images using | |||
| - [Lazy Loading](#lazy-loading) | |||
| - [Low Quality Image Placeholder Technique (LQIP)](#low-quality-image-placeholder-technique-lqip) | |||
| - [Picture support](#picture-support) | |||
| - [Background mode](#background-mode) | |||
| - [Background mode](#background-mode) - [Custom URLS](#custom-urls) | |||
| const actualURL = new URL(actual); | ||
| expect(actualURL.searchParams.get("w")).toBe("450"); | ||
| expect(actualURL.searchParams.get("h")).toBe("100"); | ||
| }); |
There was a problem hiding this comment.
Can we add a test here to ensure that the parameter override behavior outlined in the README is adhered to?
…imgix into fred/expose-url-api * 'fred/expose-url-api' of https://github.com/imgix/react-imgix: chore(deps): update dependency webpack to v4.26.0 (#226) chore(deps): update react monorepo to v16.6.3 (#223) chore(deps): update dependency prettier to v1.15.2 (#222)
…imgix into fred/expose-url-api * 'fred/expose-url-api' of https://github.com/imgix/react-imgix: Sync with Prettier
|
@jayeb this should be good to go now 😄 |
jayeb
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes a pure function
buildURLwhich allows users to generate imgix URLs directly, for instance, if they want to use the url to set the background of a custom DIV, they can accomplish that with this feature.Fixes #131
New Feature
feat(<area>): added new way to do this cool thing #issue-numberSteps to Test
Review new unit tests.