fix(deps): pin react-measure version to avoid regression #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
force-pushed
the
pin-react-measure-vers
branch
from
d923a94 to
a5a8eed
Compare
jayeb
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #341
There appears to be a regression in react-measure v2.2.6 that is causing
contentRect.bounds.widthandcontentRect.bounds.heightto return 0 in react-imgix-bg. This causes the<Background>component to render without abackground-imageproperty.This PR will pin the version of react-measure to <2.2.6 in the meantime while we gather more information over at souporserious/react-measure#137
Steps to Test
A comparison of react-measure v2.2.6 versus v2.2.5