refactor(server): use .toSorted (#10904)

immich-app · Jul 6, 2024 · 59cdbdc · 59cdbdc
1 parent 01706cc
commit 59cdbdc
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/server/src/repositories/storage.repository.spec.ts b/server/src/repositories/storage.repository.spec.ts
@@ -202,7 +202,7 @@ describe(StorageRepository.name, () => {
           .filter((entry) => entry[1])
           .map(([file]) => file);
 
-        expect(actual.sort()).toEqual(expected.sort());
+        expect(actual.toSorted()).toEqual(expected.toSorted());
       });
     }
   });

diff --git a/server/src/services/asset-media.service.spec.ts b/server/src/services/asset-media.service.spec.ts
@@ -255,13 +255,11 @@ describe(AssetMediaService.name, () => {
         }
 
         it('should be sorted (valid)', () => {
-          // TODO: use toSorted in NodeJS 20.
-          expect(valid).toEqual([...valid].sort());
+          expect(valid).toEqual(valid.toSorted());
         });
 
         it('should be sorted (invalid)', () => {
-          // TODO: use toSorted in NodeJS 20.
-          expect(invalid).toEqual([...invalid].sort());
+          expect(invalid).toEqual(invalid.toSorted());
         });
       });
     }

diff --git a/server/src/utils/mime-types.spec.ts b/server/src/utils/mime-types.spec.ts
@@ -145,7 +145,7 @@ describe('mimeTypes', () => {
 
     it('should be a sorted list', () => {
       const keys = Object.keys(mimeTypes.video);
-      expect(keys).toEqual([...keys].sort());
+      expect(keys).toEqual(keys.toSorted());
     });
 
     it('should contain only video mime types', () => {
@@ -171,7 +171,7 @@ describe('mimeTypes', () => {
 
     it('should be a sorted list', () => {
       const keys = Object.keys(mimeTypes.sidecar);
-      expect(keys).toEqual([...keys].sort());
+      expect(keys).toEqual(keys.toSorted());
     });
 
     it('should contain only xml mime types', () => {

diff --git a/server/tsconfig.json b/server/tsconfig.json
@@ -10,6 +10,7 @@
     "resolveJsonModule": true,
     "target": "es2022",
     "moduleResolution": "node16",
+    "lib": ["dom", "es2023"],
     "sourceMap": true,
     "outDir": "./dist",
     "incremental": true,