Fix some if cfg!(unix) mis-usages

[kkysen]

See #519 (comment) by @SimonIT.

I used if cfg!(unix) wrong (instead of #[cfg(unix)]), so some simple snippets don't compile on non-unix platforms anymore.

This is in c2rust-build-paths/src/lib.rs and dynamic_instrumentation/src/main.rs.

[MurraySobol]

Thanks for fixing this particular Windows error, I understand that there are (probably) several further Windows 11 errors to be fixed at some time.
Baby steps before giant leaps!!
BTW: I just reran "cargo install c2rust" and got a similar, but I think a slightly different error:
Compiling c2rust-build-paths v0.18.0
error[E0433]: failed to resolve: could not find unix in os
--> C:\Users\murra.cargo\registry\src\index.crates.io-6f17d22bba15001f\c2rust-build-paths-0.18.0\src\lib.rs:35:26
|
35 | use std::os::unix::ffi::OsStrExt;
| ^^^^ could not find unix in os

error[E0599]: no function or associated item named from_bytes found for struct OsStr in the current scope
--> C:\Users\murra.cargo\registry\src\index.crates.io-6f17d22bba15001f\c2rust-build-paths-0.18.0\src\lib.rs:37:20
|
37 | OsStr::from_bytes(path)
| ^^^^^^^^^^ function or associated item not found in OsStr

I noted that it was trying to install this:
C:>rustup update
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: syncing channel updates for 'nightly-x86_64-pc-windows-msvc'
info: checking for self-update

stable-x86_64-pc-windows-msvc unchanged - rustc 1.73.0 (cc66ad468 2023-10-03)
nightly-x86_64-pc-windows-msvc unchanged - rustc 1.75.0-nightly (a2f5f9691 2023-11-02)

info: cleaning up downloads & tmp directories

I assume that this means that I should wait for the next official update of Rust, since this change wouldn't be merged into the current build?

Thanks again for all of your efforts.

[kkysen]

Hi! It doesn't have anything to do with the version of rust itself, but you'd have to wait for the next release of c2rust to be able to cargo install c2rust the newest version. But you can cargo install --git https://github.com/immunant/c2rust/ and it'll build the latest master version, which includes the above fix.

[MurraySobol]

Thanks, I really appreciate this. I followed your instructions re: cargo install and progressed further but got this error: Compiling clap_derive v3.2.25 error: failed to run custom build command for `c2rust-ast-exporter v0.18.0 (C:\Users\murra\.cargo\git\checkouts\c2rust-2a3ef4c32beab81a\431847a\c2rust-ast-exporter)` Caused by: process didn't exit successfully: `C:\Users\murra\AppData\Local\Temp\cargo-install0BdKSm\release\build\c2rust-ast-exporter-65bc7a58e81af1f8\build-script-build` (exit code: 101) --- stderr thread 'main' panicked at c2rust-build-paths\src\lib.rs:88:44: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." } It appears that a file is missing?? Thanks for you help!! Murray

…

________________________________ From: Khyber Sen ***@***.***> Sent: Friday, November 3, 2023 1:54 PM To: immunant/c2rust ***@***.***> Cc: MurraySobol ***@***.***>; Comment ***@***.***> Subject: Re: [immunant/c2rust] Fix some `if cfg!(unix)` mis-usages (Issue #708) Hi! It doesn't have anything to do with the version of rust itself, but you'd have to wait for the next release of c2rust to be able to cargo install c2rust the newest version. But you can cargo install --git https://github.com/immunant/c2rust/ and it'll build the latest master version, which includes the above fix. — Reply to this email directly, view it on GitHub<#708 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJWUNKY6IC7QI5XVH3HPYA3YCUVU5AVCNFSM6AAAAAARIOUFAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSHA4DQMRWGA>. You are receiving this because you commented.Message ID: ***@***.***>