Added big endian feature for little endian CPU #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
requested changes
Oct 16, 2022
| @@ -97,6 +100,7 @@ fn parse_bitfield_attr( | |||
| name: name.unwrap(), | |||
| ty: ty.unwrap(), | |||
| bits: (bits.unwrap(), bits_span.unwrap()), | |||
| endian: endian, | |||
There was a problem hiding this comment.
Suggested change
| endian: endian, | |
| endian, |
Comment on lines
+31
to
+35
| let byte_index = if big_endian { | ||
| field.len() - 1 - (bit_index / 8) | ||
| } else { | ||
| bit_index / 8 | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let byte_index = if big_endian { | |
| field.len() - 1 - (bit_index / 8) | |
| } else { | |
| bit_index / 8 | |
| }; | |
| let byte_index = bit_index / 8; | |
| let byte_index = if big_endian { | |
| field.len() - 1 - byte_index | |
| } else { | |
| byte_index | |
| }; |
There was a problem hiding this comment.
Also, can you refactor all 3 (the 2 below changes, too) of these same computations into some helper function?
| field | ||
| .endian | ||
| .as_ref() | ||
| .map_or(false, |endian| endian == "big") |
There was a problem hiding this comment.
Should it only check for big or should it have to be big, little, or nothing?
There was a problem hiding this comment.
endian could be an enum, and if it had a default, this could be .unwrap_or_default(). (I lack the context here to understand whether a default endianness makes sense at all; gut says no).
Comment on lines
+235
to
+243
| let field_endians: Vec<_> = bitfields | ||
| .iter() | ||
| .map(|field| { | ||
| field | ||
| .endian | ||
| .as_ref() | ||
| .map_or(false, |endian| endian == "big") | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Suggested change
| let field_endians: Vec<_> = bitfields | |
| .iter() | |
| .map(|field| { | |
| field | |
| .endian | |
| .as_ref() | |
| .map_or(false, |endian| endian == "big") | |
| }) | |
| .collect(); | |
| let field_endians = bitfields | |
| .iter() | |
| .map(|field| { | |
| field | |
| .endian | |
| .as_ref() | |
| .map_or(false, |endian| endian == "big") | |
| }) | |
| .collect::<Vec<_>>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle big endian data on little endian CPU.
Useful for dealing with network data.