-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for require.resolve #1216
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, however, unless it’s under an option. Can we make that change?
@ljharb was thinking the same thing, yeah I'll make a version using an option |
Closing in favor of #1217 |
I'm going to keep the two in sync; orphaned PRs clutter the log. |
@ljharb why is this a breaking change if feels semver minor to me, in that it is sortof a bugfix, but broad enough that it qualifies as an added feature. I'd prefer this over require-ing (pun intended) users to discover and enable this behavior. |
@benmosher There may be some who are using |
fair enough, I guess can just try to make the note to bump it to on-by-default in v3. |
@benmosher new warnings are almost always a breaking change. |
Closes #585
Related to discussion in #1035 (link to comment).
So far I've only added
require.resolve
forcommonjs
withno-unresolved
, let me know if I should add it anywhere else.