feat:add an ignore option for 'no-extraneous-dependencies' #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
Duplicate of #1227 (please try not to open duplicate PRs) |
ljharb
requested changes
Nov 6, 2018
| @@ -15,10 +15,20 @@ This rule supports the following options: | |||
|
|
|||
| `peerDependencies`: If set to `false`, then the rule will show an error when `peerDependencies` are imported. Defaults to `false`. | |||
|
|
|||
| `ignore`: Some modules can be ignored by the ignore parameter.It supports regular expressions | |||
There was a problem hiding this comment.
I’m pretty opposed to options that are regexes; globs would be sufficient.
Separately:
Suggested change
| `ignore`: Some modules can be ignored by the ignore parameter.It supports regular expressions | |
| `ignore`: Some modules can be ignored by the `ignore` parameter. It supports regular expressions. |
| @@ -185,6 +199,7 @@ module.exports = { | |||
| allowDevDeps: testConfig(options.devDependencies, filename) !== false, | |||
| allowOptDeps: testConfig(options.optionalDependencies, filename) !== false, | |||
| allowPeerDeps: testConfig(options.peerDependencies, filename) !== false, | |||
| ignore: (options.ignore || []).map(p => new RegExp(p)), | |||
|
This seems like a strange approach to fix the problem of being unable to have an alias that’s a valid package name (with an @). Maybe that should be fixed instead? |
This is really not a good solution. I will close this pr. |
This was referenced Sep 16, 2021
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the alias module starts with "@", the current "no-extraneous-dependencies" rule will report an error in the case of "@custom/XXX".