Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack resolver plugin #377

Merged
merged 3 commits into from
Jul 14, 2016
Merged

Conversation

Rogeres
Copy link
Contributor

@Rogeres Rogeres commented Jun 14, 2016

Hello.

I use webpack.ResolverPlugin in my project in order to add my own resolvers:

https://github.com/webpack/docs/wiki/list-of-plugins#resolverplugin

eslint-import-resolver-webpack is not supporting such a way adding plugins now. This pull request solves the problem (see the code).

@benmosher
Copy link
Member

Ah, cool! Thanks!

Why filter to just ResolverPlugin, though? Do you anticipate other configured plugins may be configured that would be wasteful or wrong?

@Rogeres
Copy link
Contributor Author

Rogeres commented Jun 15, 2016

I supported only webpack.Resolver Plugin, because it seems to be unnecessary to support other plugins.

@benmosher
Copy link
Member

Fair enough. A good start, for sure. I don't know enough about Webpack plugins to know if it would hurt to just apply all of them.

@le0nik: do you have any thoughts on this? I can't remember if you had custom plugins or were just trying to use this one.

@benmosher benmosher modified the milestone: v1.10.0 Jun 21, 2016
@benmosher benmosher added this to the patch milestone Jul 3, 2016
@benmosher benmosher modified the milestones: v1.10.3, patch Jul 12, 2016
@benmosher benmosher merged commit eaf867c into import-js:master Jul 14, 2016
@renaudtertrais
Copy link

1.10.4 ?

@benmosher
Copy link
Member

Probably 0.4.0 of the Webpack resolver.

Should be out some time next week.

benmosher added a commit that referenced this pull request Jul 17, 2016
@benmosher
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants