-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #564: Fix tests not running due to Espree bump #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks :-)
@benmosher ping, it'd be nice to merge this ASAP to unbreak master |
I want to take a closer look at this. The tests run with Espree because it's the default parser; I'm not comfortable just changing it to sate Travis without better understanding why they're failing. All the post-ES2015 ones should have been using Babel already, so what would change in Espree to break the valid ES6 ones? |
(taking a look now) |
also, the most trivial of line formatting changes
I updated the broken test. Though I guess the message changed because babel-eslint reports the error differently. I'll merge once it goes green? |
1 similar comment
@ljharb you may fire when ready |
Fix #564: Fix tests not running due to Espree bump.
I changed the tests to use babel-eslint, because they are now invalid with Espree 3.2.0.
One of the tests didn't work correctly with both parsrs, so I just disabled it.
Blocks #555
cc @ljharb