Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #564: Fix tests not running due to Espree bump #565

Merged
merged 2 commits into from
Sep 17, 2016

Conversation

jfmengels
Copy link
Collaborator

Fix #564: Fix tests not running due to Espree bump.

I changed the tests to use babel-eslint, because they are now invalid with Espree 3.2.0.
One of the tests didn't work correctly with both parsrs, so I just disabled it.
Blocks #555

cc @ljharb

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 97.697% when pulling 863de65 on fix-parser-tests into 515d159 on master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :-)

@ljharb
Copy link
Member

ljharb commented Sep 17, 2016

@benmosher ping, it'd be nice to merge this ASAP to unbreak master

@benmosher
Copy link
Member

I want to take a closer look at this. The tests run with Espree because it's the default parser; I'm not comfortable just changing it to sate Travis without better understanding why they're failing.

All the post-ES2015 ones should have been using Babel already, so what would change in Espree to break the valid ES6 ones?

@benmosher
Copy link
Member

(taking a look now)

also, the most trivial of line formatting changes
@benmosher
Copy link
Member

I updated the broken test. Though I guess the message changed because babel-eslint reports the error differently.

I'll merge once it goes green?

@coveralls
Copy link

coveralls commented Sep 17, 2016

Coverage Status

Coverage remained the same at 97.837% when pulling a1386ee on fix-parser-tests into 515d159 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.837% when pulling a1386ee on fix-parser-tests into 515d159 on master.

@benmosher benmosher merged commit 12bf6da into master Sep 17, 2016
@benmosher benmosher deleted the fix-parser-tests branch September 17, 2016 20:35
@benmosher
Copy link
Member

@ljharb you may fire when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants