Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary calls cannot be canceled #252

Closed
virtuald opened this issue Oct 3, 2018 · 1 comment
Closed

Unary calls cannot be canceled #252

virtuald opened this issue Oct 3, 2018 · 1 comment

Comments

@virtuald
Copy link
Contributor

virtuald commented Oct 3, 2018

It seems the underlying unary method returns an object with a close function, but the generated code for unary functions in *_pb_service.js don't have return values.

unary function: https://github.com/improbable-eng/grpc-web/blob/master/ts/src/unary.ts#L62

Generated code: https://github.com/improbable-eng/grpc-web/blob/master/example/ts/_proto/examplecom/library/book_service_pb_service.js#L57
virtuald added a commit to virtuald/ts-protoc-gen that referenced this issue Oct 15, 2018
@virtuald
Allow canceling unary calls
301dc73 
- Fixes improbable-eng/grpc-web#252
@virtuald virtuald mentioned this issue Oct 15, 2018
Merged
virtuald added a commit to virtuald/ts-protoc-gen that referenced this issue Oct 16, 2018
@virtuald
Allow canceling unary calls
e6c5d20 
- Fixes improbable-eng/grpc-web#252
jonnyreeves pushed a commit to improbable-eng/ts-protoc-gen that referenced this issue Oct 16, 2018
@virtuald @jonnyreeves
Allow canceling unary calls (#124)
7846e2f 
* Allow canceling unary calls

- Fixes improbable-eng/grpc-web#252

* Update examples
@virtuald
Copy link
Contributor Author

Fixed in improbable-eng/ts-protoc-gen#124

chrisgervang pushed a commit to chrisgervang/flowtype-protoc-gen that referenced this issue Nov 14, 2018
@virtuald @chrisgervang
Allow canceling unary calls (improbable-eng#124)
6b4d98c 
* Allow canceling unary calls

- Fixes improbable-eng/grpc-web#252

* Update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@virtuald