Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate grpc-web-node-http-transport package so it's under the @improbable-eng org. on npm. #299

Merged
merged 2 commits into from
Jan 13, 2019
Merged

Migrate grpc-web-node-http-transport package so it's under the @improbable-eng org. on npm. #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f9028b
Migrate grpc-web-node-http-transport package so it's under the @impro…
jonny-improbable Jan 13, 2019
f3ec8cf
Mess around with package lock files...
jonny-improbable Jan 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/grpc-web-node-http-transport/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# grpc-web-node-http-transport
# @improbable-eng/grpc-web-node-http-transport
Node HTTP Transport for use with [@improbable-eng/grpc-web](https://github.com/improbable-eng/grpc-web)

## Usage
When making a gRPC request, specify this transport:

```typescript
import { grpc } from '@improbable-eng/grpc-web';
import { NodeHttpTransport } from 'grpc-web-node-http-transport';
import { NodeHttpTransport } from '@improbable-eng/grpc-web-node-http-transport';

grpc.invoke(MyService.DoQuery, {
host: "https://example.com",
Expand All @@ -18,7 +18,7 @@ grpc.invoke(MyService.DoQuery, {
Alternatively specify the Default Transport when your server/application bootstraps:
```typescript
import { grpc } from "@improbable-eng/grpc-web";
import { NodeHttpTransport } from "grpc-web-node-http-transport";
import { NodeHttpTransport } from "@improbable-eng/grpc-web-node-http-transport";

// Do this first, before you make any grpc requests!
grpc.setDefaultTransport(NodeHttpTransport());
Expand Down
10 changes: 8 additions & 2 deletions client/grpc-web-node-http-transport/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions client/grpc-web-node-http-transport/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "grpc-web-node-http-transport",
"version": "0.0.1",
"name": "@improbable-eng/grpc-web-node-http-transport",
"version": "0.0.2",
"description": "Node HTTP Transport for use with @improbable-eng/grpc-web",
"main": "lib/index.js",
"repository": {
Expand All @@ -13,13 +13,15 @@
"build": "tsc",
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@improbable-eng/grpc-web": "^0.8.0"
},
"author": "",
"author": "Improbable",
"license": "Apache-2.0",
"peerDependencies": {
"@improbable-eng/grpc-web": ">=0.7.0"
},
"devDependencies": {
"@improbable-eng/grpc-web": "^0.8.0",
"@types/node": "^10.12.0",
"google-protobuf": "^3.2.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...to satisfy @improbable-eng/grpc-web's peerDependency

"typescript": "^3.1.3"
}
}
1 change: 0 additions & 1 deletion client/grpc-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"dist"
],
"peerDependencies": {
"@types/google-protobuf": "^3.2.5",
Copy link
Contributor Author

@jonny-improbable jonny-improbable Jan 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost certain this was a mistake.

This package provides TypeScript definitions which are only required during compilation (and already satisfied as a devDependency); consumers do not need to fulfil this dependency as they are not expected to compile this package.

"google-protobuf": "^3.2.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion integration_test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"event-stream": "^3.3.4",
"google-protobuf": "^3.2.0",
"@improbable-eng/grpc-web": "^0.8.0",
"grpc-web-node-http-transport": "^0.0.1",
"@improbable-eng/grpc-web-node-http-transport": "^0.0.2",
"typedarray": "0.0.6"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion integration_test/ts/src/testRpcCombinations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
corsHost
} from "../../hosts-config";
import {grpc} from "@improbable-eng/grpc-web";
import {NodeHttpTransport} from "grpc-web-node-http-transport";
import {NodeHttpTransport} from "@improbable-eng/grpc-web-node-http-transport";

type TestConfig = {
testHostUrl: string,
Expand Down