Replace usage of Object.assign (#110)

The grpc-web service stub code generated by ts-protoc-gen is invoking an ES6 function (`Object.assign`) which is tricking webpack into treating the modules as ES6 modules instead of ES5 modules. Replacing the `Object.assign` invocation with some vanilla ES5 results in webpack correctly identify the module as a CommonJS module and thereby exposing the `exports` object to the scope of the function. Fixes #103
improbable-eng · Sep 12, 2018 · 687bcc7 · 687bcc7
1 parent 5b06c73
commit 687bcc7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/examples/generated/proto/examplecom/simple_service_pb_service.js b/examples/generated/proto/examplecom/simple_service_pb_service.js
diff --git a/examples/generated/proto/orphan_pb_service.js b/examples/generated/proto/orphan_pb_service.js
diff --git a/src/service/grpcweb.ts b/src/service/grpcweb.ts
@@ -334,7 +334,10 @@ function printUnaryStubMethod(printer: CodePrinter, method: RPCMethodDescriptor)
                  .printLn(`onEnd: function (response) {`)
           .indent().printLn(`if (callback) {`)
             .indent().printLn(`if (response.status !== grpc.Code.OK) {`)
-              .indent().printLn(`callback(Object.assign(new Error(response.statusMessage), { code: response.status, metadata: response.trailers }), null);`)
+              .indent().printLn(`var err = new Error(response.statusMessage);`)
+                       .printLn(`err.code = response.status;`)
+                       .printLn(`err.metadata = response.trailers;`)
+                       .printLn(`callback(err, null);`)
             .dedent().printLn(`} else {`)
               .indent().printLn(`callback(null, response.message);`)
             .dedent().printLn(`}`)