Fix replace all bug in filePathFromProtoWithoutExtension #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, although I propose we move unit tests to sit alongside source files with a .spec.ts extension. This would require a new npm script (npm run test:unit) and a change to the .npmignore to exclude *.spec.ts from being published to npm. LMKWYT. |
|
@easyCZ did you want me to land this as-is - happy to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which occurs for users storing their
protodefinitions inside a.protodirectory.The bug is caused by
filePathFromProtoWithoutExtensionreplacing all occurrences of.protowhen renaming a file instead of just the file suffix.A drive-by improvement to the documentation of ts-protoc-gen entry point.