npm-install: do_npm_*(): cd to ${B} #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
Related bitbake change has been introduced after krogoth release. So this fix is relevant for morty and upstream only. |
|
BTW npm-install-global seems to be working fine w/o this fix. At least I didn't observed any issues building node-red using morty branches. |
|
Are you sure package.json is always in ${B} and not in ${S}? |
|
IIUC this is the case for npm-install class: B is assigned to ${S} on top of npm-install.bblcass file. |
Change working directory to ${S} prior to running tasks from npm-install
class. This change is needed due to bitbake commit
67a7b8b021badc17d8fdf447c250e79d291e75f7.
Without this change do_npm_* functions are executed with ${TOPDIR}
as a rootdir. As a result they fail to find package.json.
Signed-off-by: Sergey Matyukevich <[email protected]>
|
PR update: v1 -> v2 Make change more future-proof: replace ${B} by ${S} since package.json normally belongs to source directory rather than to build directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change working directory to ${B} prior to running tasks from npm-install
class. This change is needed due to bitbake commit
67a7b8b021badc17d8fdf447c250e79d291e75f7.
Without this change do_npm_* functions are executed with ${TOPDIR}
as a rootdir. As a result they fail to find package.json.
Signed-off-by: Sergey Matyukevich [email protected]