-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backend for Policy upload and store #251
Conversation
3a84394
to
3c5aaef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 82.40% 1.49% -80.91%
==========================================
Files 10 117 +107
Lines 358 28635 +28277
==========================================
+ Hits 295 429 +134
- Misses 43 28149 +28106
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
The changes here are looking good. Guessing this still needs to be worked into the main |
b615ccc
to
ce54a53
Compare
Not sure if I got it. I also added an e2e with a Policy dsse envelope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as is. I had a bit of wild 🤠 idea I suggested for storePolicy.
I spent a bit of time thinking if we could consolidate any of the code between storePolicy and storeAttestation but, they're just different enough.
Great work Kairo! 🎉
There's nothing to me here that jumps out. All makes sense and is minimal, clean and easy to follow 😄 |
Integration during the Policy upload and store in SQL and ObjectStorage fix in-toto#235 Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
ce54a53
to
0ab4698
Compare
@jkjell rebased and solved the conflicts. |
Integration during the Policy upload and store in SQL and ObjectStorage
What this PR does / why we need it
Description
Which issue(s) this PR fixes (optional)
fixes #235
Acceptance Criteria Met
Special notes for your reviewer: