Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backend for Policy upload and store #251

Merged
merged 2 commits into from
May 7, 2024

Conversation

kairoaraujo
Copy link
Collaborator

Integration during the Policy upload and store in SQL and ObjectStorage

What this PR does / why we need it

Description

Which issue(s) this PR fixes (optional)

fixes #235

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

@kairoaraujo kairoaraujo force-pushed the store_policy_backend branch 2 times, most recently from 3a84394 to 3c5aaef Compare April 25, 2024 15:21
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 1.49%. Comparing base (a035c62) to head (0ab4698).
Report is 64 commits behind head on main.

Files Patch % Lines
internal/metadatastorage/sqlstore/store.go 0.00% 78 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #251       +/-   ##
==========================================
- Coverage   82.40%   1.49%   -80.91%     
==========================================
  Files          10     117      +107     
  Lines         358   28635    +28277     
==========================================
+ Hits          295     429      +134     
- Misses         43   28149    +28106     
- Partials       20      57       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhailswift
Copy link
Member

The changes here are looking good. Guessing this still needs to be worked into the main Store call?

@kairoaraujo kairoaraujo marked this pull request as ready for review April 26, 2024 09:07
@kairoaraujo
Copy link
Collaborator Author

The changes here are looking good. Guessing this still needs to be worked into the main Store call.

Not sure if I got it.
This implementation is minimal but enables the store to download the policy. ☺️

I also added an e2e with a Policy dsse envelope.

jkjell
jkjell previously approved these changes May 1, 2024
Copy link
Member

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as is. I had a bit of wild 🤠 idea I suggested for storePolicy.

I spent a bit of time thinking if we could consolidate any of the code between storePolicy and storeAttestation but, they're just different enough.

Great work Kairo! 🎉

internal/metadatastorage/sqlstore/store.go Show resolved Hide resolved
@ChaosInTheCRD
Copy link
Collaborator

There's nothing to me here that jumps out. All makes sense and is minimal, clean and easy to follow 😄

ChaosInTheCRD
ChaosInTheCRD previously approved these changes May 2, 2024
Integration during the Policy upload and store in SQL and ObjectStorage

fix in-toto#235

Signed-off-by: Kairo Araujo <[email protected]>
@kairoaraujo
Copy link
Collaborator Author

@jkjell rebased and solved the conflicts.

@jkjell jkjell merged commit b5a98aa into in-toto:main May 7, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Integration during the Policy upload and store in SQL and ObjectStorage
4 participants