Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of testifysec from chart. #259

Merged
merged 1 commit into from
May 3, 2024

Conversation

matglas
Copy link
Contributor

@matglas matglas commented May 3, 2024

What this PR does / why we need it

Remove mention of testifysec from chart.

Which issue(s) this PR fixes (optional)

Fixes #258

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

@matglas
Copy link
Contributor Author

matglas commented May 3, 2024

It looks like my changes are failing on something that is already in the main branch.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.55%. Comparing base (a035c62) to head (76af827).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #259       +/-   ##
==========================================
- Coverage   82.40%   1.55%   -80.85%     
==========================================
  Files          10     117      +107     
  Lines         358   28561    +28203     
==========================================
+ Hits          295     444      +149     
- Misses         43   28061    +28018     
- Partials       20      56       +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo
Copy link
Collaborator

Thank you, @matglas, for the PR. 🎉

@kairoaraujo kairoaraujo merged commit 57deeb4 into in-toto:main May 3, 2024
13 of 14 checks passed
@matglas matglas deleted the 258-helmchart-testify-references branch May 3, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: Remove reference to testifysec
2 participants