Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug cause by license check. #260

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

matglas
Copy link
Contributor

@matglas matglas commented May 3, 2024

What this PR does / why we need it

Because of the license header it was not possible to install the chart anymore.
Helm is unable to parse it correctly.

Which issue(s) this PR fixes (optional)

Fixes #263

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.55%. Comparing base (a035c62) to head (311cdca).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #260       +/-   ##
==========================================
- Coverage   82.40%   1.55%   -80.85%     
==========================================
  Files          10     117      +107     
  Lines         358   28561    +28203     
==========================================
+ Hits          295     444      +149     
- Misses         43   28061    +28018     
- Partials       20      56       +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkjell jkjell merged commit ced5aa6 into in-toto:main May 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Chart can not be installed because of license file headers
3 participants