feat: allow envFrom for specifying environment variables from configmap/secrets #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap or secret Signed-off-by: Eric Wyles <[email protected]>
colek42
approved these changes
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 82.40% 1.62% -80.78%
==========================================
Files 10 120 +110
Lines 358 28856 +28498
==========================================
+ Hits 295 470 +175
- Misses 43 28329 +28286
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
wcrum
added a commit
to wcrum/charts
that referenced
this pull request
Oct 29, 2024
fix testify chart in reference to below issues: - in-toto/archivista#371 - in-toto/archivista#326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the helm chart to support envFrom in addition to env. This allows users to have the archivista environment variables in an existing configmap or secret and let kubernetes load them to the deployment through envFrom.
What this PR does / why we need it
This allows use of secrets for configuring connections and also allows for operators that configure db user/pw at deploy time to be able to supply secrets containing the connection information.
Acceptance Criteria Met
Special notes for your reviewer: