chore(ci): build images with dockerfile instead of ko #332
Conversation
|
@mikhailswift |
|
We can use this feature with KO. https://github.com/ko-build/ko/blob/main/docs/features/static-assets.md Since we are using KO for dev previews in JUDGE, and KO does not require Docker I think we should try this. |
This error is happening because the witness-run-action installs witness to the current working directory, which overwrites archivista's README.md and LICENSE file with the one packaged in witness.tar.gz, causing a dirty git tree. I have a PR out for the witness-run-action to add an option to install witness to a user defined directory. |
mikhailswift
force-pushed
the
chore/use-dockerfile
branch
8 times, most recently
from
1f3c976
to
c549bed
Compare
Our Dockerfile includes our migrations and Atlas to execute those migrations. However, the public image we are pushing is built with Ko and excludes these files/tools. This commit switches gorelease to build the image with the included Dockerfile. Signed-off-by: Mikhail Swift <[email protected]>
This updates the witness-run-action, and installs witness to a directory outside of the current source directory. This keeps our source git tree clean. Signed-off-by: Mikhail Swift <[email protected]>
mikhailswift
force-pushed
the
chore/use-dockerfile
branch
from
c549bed
to
8693927
Compare
Our Dockerfile includes our migrations and Atlas to execute those migrations. However, the public image we are pushing is built with Ko and excludes these files/tools. This commit switches gorelease to build the image with the included Dockerfile.
What this PR does / why we need it
Description
Which issue(s) this PR fixes (optional)
(optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged)*Fixes #
Acceptance Criteria Met
Special notes for your reviewer: