Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #339

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Update README.md #339

merged 2 commits into from
Jul 31, 2024

Conversation

rgreinho
Copy link
Contributor

@rgreinho rgreinho commented Jul 29, 2024

Updates the configuration section describing the environment variables and their default values.

Drive-by:

  • Fixes the Markdown lint violations and formats using prettier.

What this PR does / why we need it

Description

Which issue(s) this PR fixes (optional)

(optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged)*

Fixes #

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Updates the configuration section describing the nevironment variables
and their default values.

Drive-by:
- Fixes the Markdown lint violations and formats using prettier.

Signed-off-by: Rémy Greinhofer <[email protected]>
@rgreinho
Copy link
Contributor Author

I am not sure what I can do about the db-migrations test failing.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.64%. Comparing base (a035c62) to head (3c285f5).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #339       +/-   ##
==========================================
- Coverage   82.40%   1.64%   -80.76%     
==========================================
  Files          10     120      +110     
  Lines         358   28856    +28498     
==========================================
+ Hits          295     476      +181     
- Misses         43   28323    +28280     
- Partials       20      57       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo
Copy link
Collaborator

I am not sure what I can do about the db-migrations test failing.

I'm investigating it.

@kairoaraujo
Copy link
Collaborator

Thank you, @rgreinho, for the PR improving our doc. 🎉
Merging it. 🚀

@kairoaraujo kairoaraujo merged commit 60a63ff into in-toto:main Jul 31, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants