chore: disable sql connection when graphql is disabled #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailswift
force-pushed
the
chore/disable-sql
branch
from
3cc423f
to
fff128e
Compare
jkjell
requested changes
Oct 23, 2024
mikhailswift
force-pushed
the
chore/disable-sql
branch
from
fff128e
to
31146f7
Compare
kairoaraujo
approved these changes
Oct 25, 2024
kairoaraujo
requested changes
Oct 25, 2024
jkjell
force-pushed
the
chore/disable-sql
branch
from
31146f7
to
35c1628
Compare
mikhailswift
force-pushed
the
chore/disable-sql
branch
2 times, most recently
from
3b6127a
to
b5f1f1c
Compare
Signed-off-by: Mikhail Swift <[email protected]>
mikhailswift
force-pushed
the
chore/disable-sql
branch
from
b5f1f1c
to
deff761
Compare
|
Fixed the tests |
jkjell
approved these changes
Oct 25, 2024
kairoaraujo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
A user has expressed the desire to disable the SQL metadata store and graphql endpoints entirely, and just use Archivista to store and download attestations. This PR adds another config variable to support this, and disables both GraphQL and the SQL endpoint features if configured to do so.
Which issue(s) this PR fixes (optional)
(optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged)*Fixes #
Acceptance Criteria Met
Special notes for your reviewer: