-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/timestamps #41
Feat/timestamps #41
Conversation
Pull Request Test Coverage Report for Build 3472136889
💛 - Coveralls |
Sample query to test this:
example results from above query:
Will get this pushed to the dev instance tomorrow. |
Adds timestamp metadata to any signatures that may have timestamping information attached.
Archivist used the Store and Download functions which returned envelopes, parsed on either end by go's json decoder and encoder. This could cause a new line to be appended to an envelope after encoding, causing a difference in the envelope's hash. By using the Reader/Writer methods archivistctl just passes through the raw bytes to archivist, allowing the server to decode and verify any information before passing those raw bytes to object storage. This ensures gitoids and shasums of envelopes remain consistent.
71d9a0d
to
28a7691
Compare
timestampGT: Time | ||
timestampGTE: Time | ||
timestampLT: Time | ||
timestampLTE: Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be great!
SetKeyID(sig.KeyID). | ||
SetSignature(base64.StdEncoding.EncodeToString(sig.Signature)). | ||
SetDsse(dsse). | ||
Save(ctx) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
for _, timestamp := range sig.Timestamps { | ||
timestampedTime, err := timeFromTimestamp(timestamp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong, but we will only store the time if a timestamp exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I’m splitting up the other time stuff currently
Great Work! |
* feat: add timestamp metadata to database Adds timestamp metadata to any signatures that may have timestamping information attached. * fix: prevent archivistctl from modifiying envelope hashes Archivist used the Store and Download functions which returned envelopes, parsed on either end by go's json decoder and encoder. This could cause a new line to be appended to an envelope after encoding, causing a difference in the envelope's hash. By using the Reader/Writer methods archivistctl just passes through the raw bytes to archivist, allowing the server to decode and verify any information before passing those raw bytes to object storage. This ensures gitoids and shasums of envelopes remain consistent.
Also,
Archivist used the Store and Download functions which returned
envelopes, parsed on either end by go's json decoder and encoder. This
could cause a new line to be appended to an envelope after encoding,
causing a difference in the envelope's hash.
By using the Reader/Writer methods archivistctl just passes through the
raw bytes to archivist, allowing the server to decode and verify any
information before passing those raw bytes to object storage. This
ensures gitoids and shasums of envelopes remain consistent.