-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify specification on Bundle and Envelope media types #283
Clarify specification on Bundle and Envelope media types #283
Conversation
Signed-off-by: Marcela Melara <[email protected]>
f618532
to
9daefb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this PR improves clarity, thanks for working on it.
I'm worried we're not consistent in using capitalised names for components in the attestation model (Bundle, Attestation, Envelope, Statement, Predicate, etc). Should we do a consistency pass and create some contributor documentation explaining conventions like this?
Agreed, I don't think we're being consistent on this right now. Personally, I find it helpful to capitalize these terms denote when we're talking about attestation model components vs. not, but I wasn't sure if everyone would agree. If we do, then we should definitely follow your suggestion of doing a consistency pass and adding documentation for this. |
Co-authored-by: Joshua Lock <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
280304e
to
2310e5b
Compare
02ae39f
to
53df5a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments / updates aside, this LGTM.
53df5a2
to
a767a8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
6338c91
to
54ad0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thank you!
Signed-off-by: Marcela Melara <[email protected]>
Co-authored-by: Joshua Lock <[email protected]>
999c377
to
637b103
Compare
Signed-off-by: Marcela Melara <[email protected]>
This PR updates the specs for Bundles and Envelopes to more formally describe conventions around attestation layer media types when these are stored in arbitrary storage systems, per #271 (comment)
Fixes #271