revert: fix: repetitive and incorrect log lines on witness verify (…
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkjell
previously approved these changes
Aug 22, 2024
mikhailswift
force-pushed
the
chore/revert-broken-policy-eval
branch
3 times, most recently
from
956ee36
to
4cfc894
Compare
|
@mikhailswift am I correct that you basically copied the tests from witness into go-witness to do the verify_test? It all looks good to me. I can't approve but if I could I would 😄 |
kairoaraujo
approved these changes
Aug 23, 2024
…317)" This reverts commit 26ee2dc. This commit breaks policy evaluations, causing good policies to fail. Signed-off-by: Mikhail Swift <[email protected]>
Signed-off-by: Mikhail Swift <[email protected]>
mikhailswift
force-pushed
the
chore/revert-broken-policy-eval
branch
from
4cfc894
to
b46fc00
Compare
Correct, with some tweaks. We'll need to add more testing around policy evaluations to prevent this type of thing from happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#317)"
This reverts commit 26ee2dc.
This commit breaks policy evaluations, causing good policies to fail.
Also added is a test to catch these types of errors in the future. This is just a base case test; we will need to expand our testing around policy verification to ensure this is more resilient to breakages.
What this PR does / why we need it
Description
Which issue(s) this PR fixes (optional)
(optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged)*Fixes #
Acceptance Criteria Met
Special notes for your reviewer: