Add sublayout verification capabilities #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Also looking into why builds failed. |
lukpueh
reviewed
Feb 15, 2019
|
Latest commits potentially fix in-toto/in-toto#254, if accepted, I'll push a similar fix to the reference implementation. |
lukpueh
requested changes
Feb 20, 2019
There was a problem hiding this comment.
Thanks for the changes, code-wise it's good to merge.
Please consider updating code comments and docstrings as per my inline suggestions, and take another look at the two style suggestions in my last review summary, I think you missed them.
|
Great work, @adityasaky! Let's merge and add more tests with #22 |
This was referenced Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces capabilities for sublayout verification. There are still a couple of things left to do, but I went ahead and opened this to start any relevant discussions.
Things left to do:
2. Add some comments3. Run the files through gofmt4. Line wrapping