fix(install-witness.sh): ensure compatibility with macOS for checksum verification #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for witness-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Tested on both macOS and Ubuntu. |
jkjell
approved these changes
Jun 1, 2024
… verification The install-witness.sh script did not work on macOS due to the absence of the sha256sum command. This patch adds a check to use shasum -a 256 if sha256sum is not available, ensuring the script runs correctly on macOS. - Added a conditional check to use shasum -a 256 when sha256sum is not found - Updated the FILE_CHECKSUM assignment to support both commands Closes in-toto#458 Signed-off-by: Frederick F. Kautz IV <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install-witness.sh script did not work on macOS due to the absence of the sha256sum command.
This patch adds a check to use shasum -a 256 if sha256sum is not available, ensuring the script
runs correctly on macOS.
Closes #458
Signed-off-by: Frederick F. Kautz IV [email protected]