Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-problematic files in the destination folder #1

Closed
inadarei opened this issue Mar 12, 2017 · 3 comments
Closed

Ignore non-problematic files in the destination folder #1

inadarei opened this issue Mar 12, 2017 · 3 comments
Assignees

Comments

@inadarei
Copy link
Owner

Currently Justgo requires the destination folder to be completely empty. This can be annoying if you are working in a freshly created github workspace which will typically have .git, .gitignore and README.md.

JustGo should consider presence of these three items to be equivalent of folder being empty, in order to provide better user-experience during bootstrapping.

@inadarei inadarei self-assigned this Mar 12, 2017
@cmlicata
Copy link
Collaborator

cmlicata commented Apr 23, 2017

@inadarei, I see this being problematic here since the intention is to preserve these non-problematic files.

I think the best solution would be to simply remove the README.md file from the archive and remove this line altogether?

What do you think?

@inadarei
Copy link
Owner Author

I assume you are saying that out of the three one (README) is a problem. In which case I agree.

One of two choices:

  1. unzip somewhere else, not at the destination, do cleanup and then move - not my favorite choice
  2. if you notice .git, .gitignore and README are already present:
    1. Ignore presence of .git and .gitignore
    2. In case of README - move it to some unique place (e.g. "uuid" and temp folder) do everything as it would be done normally, move it back. Probably a nice opportunity to use defer, by the way.

@cmlicata
Copy link
Collaborator

@inadarei, ok I will add #2 to my current implementation and submit a PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants