Ignore non-problematic files in destination folder #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inadarei
reviewed
Aug 5, 2017
| if filesToMove != nil { | ||
| for _, file := range filesToMove { | ||
| srcPath := filepath.Join(path, file) | ||
| tmpFilePath := filepath.Join(os.TempDir(), file) |
There was a problem hiding this comment.
By using os.TempDir() directly, you will destroy any pre-existing files there which may have the same name(s) as the files you are stashing away. In extreme scenarios - you may run into even more severe conflicting cases.
Rather, let's make sure we create a unique folder under os.TempDir() and do our dirty work there.
inadarei
reviewed
Aug 5, 2017
| if filesToMove != nil { | ||
| for _, file := range filesToMove { | ||
| srcPath := filepath.Join(path, file) | ||
| tmpFilePath := filepath.Join(os.TempDir(), file) |
There was a problem hiding this comment.
By naming this variable tmpFilePath (which was already used for a different purpose on line 64) you are causing confusion and possibility of conflict.
|
This works as required, minus couple of minor issues. I fixed those issues and will be merging shortly. Thank you for your valuable contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@inadarei, this addresses #1.
I also addressed the following, based upon the discussion surrounding the issue:
README.md).