IWF-385: return channel sizes for RPC #502
Conversation
| "testing" | ||
| ) | ||
|
|
||
| func TestSignalWorkflowNoWorkflowId(t *testing.T) { |
There was a problem hiding this comment.
Moved from another file as it's a new test and the file was too big
longquanzheng
changed the title
integ/util.go
Outdated
| @@ -178,6 +178,12 @@ func doStartIwfServiceWithClient(config IwfServiceTestConfig) (uclient uclient.U | |||
| } | |||
| } | |||
|
|
|||
| func panicAError(err error) { | |||
integ/workflow/locking/routers.go
Outdated
| @@ -107,6 +111,19 @@ func (h *handler) ApiV1WorkflowWorkerRpc(c *gin.Context) { | |||
| }) | |||
| return | |||
| } | |||
|
|
|||
| signalChannelInfo := (*req.SignalChannelInfos)[UnusedSignalChannelName] | |||
| if signalChannelInfo.GetSize() != 4 { | |||
There was a problem hiding this comment.
I am not following this part. What is this check? Why the size is expected to be 4?
There was a problem hiding this comment.
I just added a few comments to the test.
The signals are sent in a different file locking_test.go.
Changed to a constant to be more clear Lol.
| infos := map[string]iwfidl.ChannelInfo{} | ||
| for name, l := range i.receivedData { | ||
| infos[name] = iwfidl.ChannelInfo{ | ||
| Size: ptr.Any(int32(len(l))), |
There was a problem hiding this comment.
Size is the number of messages, not actual data size in bytes, right?
There was a problem hiding this comment.
Yeah, l is the list of all the messages. So len(l) is the number of the messages.
receivedData is a map of list.
| @@ -94,6 +94,7 @@ func doTestLockingWorkflow(t *testing.T, backendType service.BackendType, config | |||
| panicAtHttpError(err, httpResp) | |||
|
|
|||
| for i := 0; i < 4; i++ { | |||
| // send 4 unused signals at the beginning to validate the ChannelInfo feature | |||
| @@ -23,6 +26,16 @@ func (i *InternalChannel) GetAllReceived() map[string][]*iwfidl.EncodedObject { | |||
| return i.receivedData | |||
| } | |||
|
|
|||
| func (i *InternalChannel) GetInfos() map[string]iwfidl.ChannelInfo { | |||
| infos := map[string]iwfidl.ChannelInfo{} | |||
There was a problem hiding this comment.
Since we know the size, can we not create a map with a preallocated size here?
| infos := map[string]iwfidl.ChannelInfo{} | |
| infos := make(map[string]iwfidl.ChannelInfo, len(i.receivedData)) |
| @@ -237,6 +238,16 @@ func (sr *SignalReceiver) GetAllReceived() map[string][]*iwfidl.EncodedObject { | |||
| return sr.receivedSignals | |||
| } | |||
|
|
|||
| func (sr *SignalReceiver) GetInfos() map[string]iwfidl.ChannelInfo { | |||
| infos := map[string]iwfidl.ChannelInfo{} | |||
There was a problem hiding this comment.
added. Good catch :D
Description
Checklist
Related Issue
Closes #issue_number