Implement Default for iterators #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
iter-default-implementation
branch
from
db9016d to
bcdedde
Compare
This matches Default implementations for HashMap and HashSet introduced in Rust 1.70.
KamilaBorowska
force-pushed
the
iter-default-implementation
branch
from
bcdedde to
704bf5a
Compare
cuviper
reviewed
Jun 6, 2023
| @@ -438,6 +480,14 @@ impl<K, V: fmt::Debug> fmt::Debug for ValuesMut<'_, K, V> { | |||
| } | |||
| } | |||
|
|
|||
| impl<K, V> Default for ValuesMut<'_, K, V> { | |||
There was a problem hiding this comment.
Hmm, oddly std left this out, but I think it's fine.
That actually did not include |
cuviper
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches
Defaultimplementations for HashMap and HashSet introduced in Rust 1.70 (rust-lang/rust#99929).