Ensure system env var is populated

indix · May 11, 2017 · 5ef816d · 5ef816d
1 parent 1b62daa
commit 5ef816d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/utils/src/main/java/com/indix/gocd/utils/GoEnvironment.java b/utils/src/main/java/com/indix/gocd/utils/GoEnvironment.java
@@ -18,13 +18,14 @@
  */
 public class GoEnvironment {
     private Pattern envPat = Pattern.compile("\\$\\{(\\w+)\\}");
-    private Map<String, String> environment = new HashMap<String, String>();
+    private Map<String, String> environment = new HashMap<>();
 
     public GoEnvironment() {
-        this(System.getenv());
+        this.environment.putAll(System.getenv());
     }
 
     public GoEnvironment(Map<String, String> defaultEnvironment) {
+        this();
         this.environment.putAll(defaultEnvironment);
     }
 

diff --git a/utils/src/test/java/com/indix/gocd/utils/GoEnvironmentTest.java b/utils/src/test/java/com/indix/gocd/utils/GoEnvironmentTest.java
@@ -71,8 +71,7 @@ public void shouldNotReplaceUnknownEnvVariables() {
 
         assertThat(replaced, is("COUNT:1 ${DOESNT_EXIST}"));
     }
-
-
+
     @Test
     public void shouldGetHasAWSUseIamRoleTrueIfSetToTrue() {
         GoEnvironment sut = new GoEnvironment(mockEnvironmentVariables
-Original file line number
+Diff line change
@@ Expand Up / @@ -71,8 +71,7 @@ public void shouldNotReplaceUnknownEnvVariables() { @@
             assertThat(replaced, is("COUNT:1 ${DOESNT_EXIST}"));
         }
         @Test
         public void shouldGetHasAWSUseIamRoleTrueIfSetToTrue() {
             GoEnvironment sut = new GoEnvironment(mockEnvironmentVariables
@@ Expand Down @@