#5 Better logging on failure to fetch artifacts

indix · Mar 1, 2015 · f2d1f59 · f2d1f59
1 parent d57702a
commit f2d1f59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/fetch/src/main/java/com/indix/gocd/s3fetch/FetchExecutor.java b/fetch/src/main/java/com/indix/gocd/s3fetch/FetchExecutor.java
@@ -39,7 +39,9 @@ public ExecutionResult execute(TaskConfig config, final TaskExecutionContext con
         try {
             store.getPrefix(artifactPathOnS3, destination);
         } catch (Exception e) {
-            return ExecutionResult.failure("Failure while downloading artifacts", e);
+            String message = String.format("Failure while downloading artifacts - %s", e.getMessage());
+            logger.error(message, e);
+            return ExecutionResult.failure(message, e);
         }
 
         return ExecutionResult.success("Fetched all artifacts");

diff --git a/fetch/src/test/java/com/indix/gocd/s3fetch/FetchExecutorTest.java b/fetch/src/test/java/com/indix/gocd/s3fetch/FetchExecutorTest.java
@@ -81,12 +81,12 @@ public void shouldBeFailureIfUnableToFetchArtifacts() {
         Map<String, String> mockVariables = mockEnvironmentVariables.build();
         AmazonS3Client mockClient = mockClient();
         doReturn(mockClient).when(fetchExecutor).s3Client(any(GoEnvironment.class));
-        doThrow(new AmazonClientException("Exception")).when(mockClient).listObjects(any(ListObjectsRequest.class));
+        doThrow(new AmazonClientException("Exception message")).when(mockClient).listObjects(any(ListObjectsRequest.class));
 
         ExecutionResult executionResult = fetchExecutor.execute(config, mockContext(mockVariables));
 
         assertFalse(executionResult.isSuccessful());
-        assertThat(executionResult.getMessagesForDisplay(), is("Failure while downloading artifacts"));
+        assertThat(executionResult.getMessagesForDisplay(), is("Failure while downloading artifacts - Exception message"));
     }
 
     @Test