Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo or Package names with period cannot be fetched #36

Closed
haimizrael opened this issue Jun 7, 2016 · 1 comment
Closed

Repo or Package names with period cannot be fetched #36

haimizrael opened this issue Jun 7, 2016 · 1 comment

Comments

@haimizrael
Copy link
Contributor

haimizrael commented Jun 7, 2016 •
edited
Loading

If the repo or package name has a period, the s3.Fetch plugin cannot retrieve artifacts, since Go replaces periods with underscores when setting environment variables GO_PACKAGE_..._NAME.

In fact, Go replaces all special characters other than underscore with an underscore.
haimizrael added a commit to GCMGrosvenor/ARCHIVED-gocd-s3-artifacts that referenced this issue Jun 7, 2016
@haimizrael
Resolve issue indix#36: repo or package names with special characters…
99f79f7 
… won't be processed because Go escapes special characters with underscore

Replace amazonaws StringUtils with commons StringUtils
ashwanthkumar added a commit that referenced this issue Jul 3, 2016
@ashwanthkumar
Merge pull request #37 from GCMGrosvenor/features/Issue36
ba633eb 
Resolve issue #36: repo or package names with special characters won't be processed
@ashwanthkumar
Copy link
Member

Fixed via #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashwanthkumar @haimizrael