Allow S3 Fetch config with dashes in the name to still work #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| import static com.indix.gocd.utils.Constants.*; | |||
| import static org.hamcrest.Matchers.is; | |||
| import static org.hamcrest.Matchers.nullValue; | |||
There was a problem hiding this comment.
Can we remove this if we're not using it? :)
There was a problem hiding this comment.
oops! done :-)
|
LGTM - #8 |
manojlds
added a commit
that referenced
this pull request
Dec 11, 2015
Allow S3 Fetch config with dashes in the name to still work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a S3 Fetch config repo or package name contains a dash in the name, the material environment variables (GO_PACKAGE_*) are saved as an underscore (bash restriction). This can lead to confusion when the fetch configs 'appear' correct however the S3 Fetch plugin complains about the configuration.