Adds the ability to use IAM roles from EC2 instances for credentials #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,5 +14,5 @@ | |||
| <span class="form_error" ng-show="GOINPUTNAME[Destination].$error.server">{{ GOINPUTNAME[Destination].$error.server }}</span> | |||
| </div> | |||
| <div class="form_item_block"> | |||
| <p class="required">Make sure AWS_SECRET_ACCESS_KEY, AWS_ACCESS_KEY_ID and GO_ARTIFACTS_S3_BUCKET environment variables are present with appropriate values on any of pipeline / Go Environments / on all agent machines. </p> | |||
| <p class="required">Make sure either AWS_USE_IAM_ROLE or AWS_SECRET_ACCESS_KEY + AWS_ACCESS_KEY_ID, GO_ARTIFACTS_S3_BUCKET and GO_ARTIFACTS_S3_BUCKET environment variables are present with appropriate values on any of pipeline / Go Environments / on all agent machines. </p> | |||
There was a problem hiding this comment.
GO_ARTIFACTS_S3_BUCKET is repeating on both the template files.
lobsterdore
force-pushed
the
add-iam-roles
branch
from
2ec5dd3 to
0412c8a
Compare
|
@ashwanthkumar No worries at all, I've fixed that template issue. |
|
LGTM. Open source is beneficial for everyone :) Let's make sure docs are updated too? https://github.com/ind9/gocd-s3-artifacts/tree/gh-pages |
|
@manojlds do you want me to open a separate pr for the docs? |
|
@lobsterdore - if you can, then yes, please! If not, we will take care of it. Just do confirm if you want take a stab at it :) |
lobsterdore
force-pushed
the
add-iam-roles
branch
from
0412c8a to
4af4b08
Compare
lobsterdore
force-pushed
the
add-iam-roles
branch
from
4af4b08 to
99deb3f
Compare
|
@manojlds Rebased and updated, I will pop in a PR for the docs hopefully tomorrow. |
|
Documentation PR -> #22 |
ashwanthkumar
added a commit
that referenced
this pull request
Dec 22, 2015
Adds the ability to use IAM roles from EC2 instances for credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GOCD in AWS it's best practice to avoid keys and use an IAM role attached to the machine itself, this change will enable that functionality.