Making S3's storage class for artifacts configurable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now look for an environment variable - AWS_STORAGE_CLASS whose values can be one of standard, rrs or glacier. The default behaviour if none specified is standard. Fixes #23
| @@ -34,7 +56,7 @@ public void put(String from, String to, ObjectMetadata metadata) { | |||
| } | |||
|
|
|||
| public void put(PutObjectRequest putObjectRequest) { | |||
| putObjectRequest.setStorageClass(StorageClass.ReducedRedundancy); | |||
| putObjectRequest.setStorageClass(this.storageClass); | |||
There was a problem hiding this comment.
Shouldn't we set this at the time the put object request gets built? or, we don't have the info there?
There was a problem hiding this comment.
I didn't want the AWS's StorageClass leaking outside - adhan.
|
LGTM |
|
We will update the docs at the time of cutting a release. |
manojlds
added a commit
that referenced
this pull request
Feb 10, 2016
Making S3's storage class for artifacts configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded from target JVM of 1.6 to 1.7, esp given Java 7 has also reached EOL. I don't see a point in still using 1.6.
With regard to concerns raised at #23, this PR makes storage class configurable for all artifacts using
AWS_STORAGE_CLASSenvironment variable.@manojlds @Sriram-R