Refactor AWS auth across plugins and upgrade SDK #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashwanthkumar Let me know if this is inline with what you had in mind in #41 |
| @@ -187,4 +199,13 @@ public RevisionStatus getLatest(AmazonS3Client client, Artifact artifact) { | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| public static AmazonS3 getS3client(GoEnvironment env) { | |||
| AmazonS3ClientBuilder amazonS3ClientBuilder = AmazonS3ClientBuilder.standard(); | |||
There was a problem hiding this comment.
@manojlds I'm not aware of the latest client authentication chain. But does it cover all the things as specified here?
There was a problem hiding this comment.
The below in the code you referenced:
new EnvironmentVariableCredentialsProvider() - Present
new SystemPropertiesCredentialsProvider() - Present
new ProfileCredentialsProvider() - Present
new InstanceProfileCredentialsProvider() - Present
new BasicAWSCredentialsProvider(accessKey, secretKey) - Not needed. Note that the code gets the creds from env vars and then passes as params.
new AnonAWSCredentialsProvider() - Present
Also adds ECS support :)
ashwanthkumar
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.