Improve React usePage
generic type
#1451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1396, the
usePage
generic type was (re)introduced for the React adapter.When trying to use this, I've found it to be quite inconvenient because it's expecting us to pass in an entire
Page
type, which has things like theurl
,component
, etc. with the props being nested under aprops
key.This PR aims to solve that by changing the generic type to just accept the
PageProps
type.This would also make the usage consistent with the Vue version.