Fix usePage()
reactivity in Vue 2 adapter
#1527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
usePage()
hook in the Vue 2 adapter isn't actually reactive. The following doesn't work:This PR updates the Vue 2 adapter to use the same technique used in the Vue 3 adapter to solve this (see #1469).
The only issue here is that this requires Vue 2.7 features to fix this — the
computed()
andreactive()
methods. Meaning anyone who is still using Vue 2.6 will need to also upgrade to Vue 2.7 when updating to the next release of Inertia. Given that this is the only way to solve this problem, I think that's a reasonable tradeoff.