Fix <Head> vNode handling in Vue 3 adapter
#1570
Conversation
Improved node detection process for Head component which now supports fragments, conditionals and functional components. Comments nodes are now automatically discarded.
|
@craigrileyuk Hey I really appreciate you tackling this! This looks good, although a plain <Head>
<title>Home</title>
</Head>Is there a reason you're excluding nodes with children, here? else if (!isComment && !node.children) return nodeCould this just be this? else if (!isComment) return node |
@reinink Yep. That fixes the |
|
Okay great, I'll get this merged in and released. I'll probably tweak the code formatting a little to match what we normally do in this project, but really appreciate you doing the hard work here! 🙏
Well, thanks for trying either way 😊 |
|
@craigrileyuk I've tweaked the formatting here to try and simplify things — I think everything still functionally works the same, but feel free to review 😊 |
reinink
changed the title
<Head> node handling in Vue 3 adapter
reinink
changed the title
<Head> node handling in Vue 3 adapter <Head> nVode handling in Vue 3 adapter
|
This fixed has been released as part of v1.0.8 👍 |
reinink
changed the title
<Head> nVode handling in Vue 3 adapter <Head> vNode handling in Vue 3 adapter
Improved node detection process for Head component which now supports fragments, conditionals and functional components. Comments nodes are now automatically discarded.