[1.x] Fix a bug with [scroll-region] elements not restoring correct scroll positions in react adapter #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroborges
added
react
pedroborges
requested changes
Sep 6, 2024
There was a problem hiding this comment.
I tested locally and reproduced the bug with the React adapter. Your solution fixes it, @dsazup. Thank you!
The core has been rewritten to support async requests, the restoreScrollPositions method has been renamed and moved to the packages/core/src/scroll.ts file. Let's wait until that work is merged into master to rebase and merge this one 👍
|
#1803 also fixes a scroll restoration bug in the React adapter. These PRs conflict with each other but that will be easy to consolidate. |
pedroborges
changed the title
|
Fixed by #1980 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm using react and I run into a bug where I have a [scroll-region] element and after navigating back, the scroll position is not restored, even though the page has saved the positions correctly.
This happens because in the
restoreScrollPositionsmethodthis.scrollRegions()returns an empty array. It thinks that there aren't any [scroll-region] elements, because the document body hasn't been updated yet. Even though there actually is an element. Simply wrapping the whole thing insetTimeoutfixes it and positions are restored correctly.