Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Svelte version import #2002

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix Svelte version import #2002

merged 2 commits into from
Oct 9, 2024

Conversation

pedroborges
Copy link
Collaborator

Sam reported that the new svelte adapter adds ~500 kb to his app bundle size.

After some investigation I found the culprit, it’s the way we import the VERSION constant from the Svelte compiler in the createInertiaApp.ts. This PR fixes that.

Before

Screen Shot 2024-10-09 at 03 49 25

After

Screen Shot 2024-10-09 at 03 50 28

joetannenbaum
joetannenbaum approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@joetannenbaum joetannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for looking into this

@pedroborges pedroborges added the svelte Related to the svelte adapter label Oct 9, 2024
@pedroborges pedroborges requested a review from reinink October 9, 2024 14:40
@pedroborges pedroborges mentioned this pull request Oct 9, 2024
Closed
@reinink reinink merged commit 2494fd5 into master Oct 9, 2024
7 checks passed
@reinink reinink deleted the fix-svelte-import branch October 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joetannenbaum joetannenbaum joetannenbaum approved these changes

@reinink reinink Awaiting requested review from reinink

Assignees
No one assigned
Labels
svelte Related to the svelte adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroborges @joetannenbaum @reinink