Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] $page url should not include the host #2032

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[2.x] $page url should not include the host #2032

merged 1 commit into from
Oct 15, 2024

Conversation

joetannenbaum
Copy link
Contributor

This was an accidental breaking change in 2.x, previously $page.url did not include the full URL, now it does. This PR fixes that.

Fixes #2020

@joetannenbaum joetannenbaum requested a review from reinink October 14, 2024 20:00
reinink
reinink approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@reinink reinink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for better or worse I've always tried to keep the host out of the URLs in Inertia.

@joetannenbaum joetannenbaum merged commit 65602dd into master Oct 15, 2024
8 checks passed
@joetannenbaum joetannenbaum deleted the page-full-url-fix branch October 15, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroborges pedroborges pedroborges approved these changes

@reinink reinink reinink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$page.url breaking change
3 participants
@joetannenbaum @pedroborges @reinink