-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deepMerge Support for Merging Nested Arrays and Objects in Props #2069
Open
HichemTab-tech
wants to merge
5
commits into
inertiajs:master
Choose a base branch
from
HichemTab-tech:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for deep merging specified properties in page responses by introducing `deepMergeProps`. This ensures that nested objects and arrays are correctly merged instead of being overwritten, enhancing the flexibility and consistency of data handling.
This commit introduces the deepMergeProps feature in the Vue3 application, allowing for more comprehensive property merging. A corresponding test has been created to ensure the functionality operates as expected. Additionally, server routing is updated to support deepMergeProps.
Changed the component from 'DeepMergeProps' to 'MergeProps' in the /deep-merge-props route handler. This aligns the route's component usage with the updated naming conventions in the project.
Changed the component from 'DeepMergeProps' to 'MergeProps' in the /deep-merge-props route handler. This aligns the route's component usage with the updated naming conventions in the project.
Hi, any progress here ?! We really need this feature enhancement. Thanks. |
Are there any plans to merge this in? |
No idea my friend :") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for
deepMerge
functionality in Inertia.js, enabling developers to merge nested arrays and objects within props when rendering pages. This is particularly useful for situations where complex data structures, such as pagination objects or deeply nested configuration objects, need to be updated incrementally.Why This Is Useful:
Consider a scenario where you have a pagination object that contains nested properties like
data
,meta
, andlinks
:With
deepMerge
, thedata
array can be properly merged by appending new items, while other nested properties likemeta
andlinks
are also updated incrementally. This ensures that only the necessary parts of the pagination object are modified without replacing the entire object, which can help maintain the consistency of the data across requests.Related PR:
This PR works in conjunction with the newly added deep merging logic in the Inertia-laravel repository. Please see inertia-laravel PR #679 for details on the client-side implementation.
Fixes #2068