Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a displayName to the PageContext #351

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

hailwood
Copy link
Contributor

Presently in the react devtools we have this:
image

Context.Provider there being the pageContext we create as that is the default name,
but it's possible to name the contexts which makes navigating the react tree much nicer - After this pull request it will display as:
image

@reinink
Copy link
Member

reinink commented Dec 14, 2020

Interesting, we do something similar in Vue to make the devtools nicer to use.

Ping @sebastiandedeyne for review. 👍

@sebastiandedeyne sebastiandedeyne merged commit 12d958d into inertiajs:master Dec 15, 2020
@sebastiandedeyne
Copy link
Contributor

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants